[BUGFIX beta] Fix positional params in contextual components with dot syntax #12626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @mixonic - r? |
|
Sauce is failing :( |
|
Restarted it. |
| @@ -59,8 +59,7 @@ ComponentNodeManager.create = function ComponentNodeManager_create(renderNode, e | |||
| configureCreateOptions(attrs, createOptions); | |||
|
|
|||
| // If there is a controller on the scope, pluck it off and save it on the | |||
| // component. This allows the component to target actions sent via | |||
| // `sendAction` correctly. | |||
| // component. This allows the component to target actions sent via // `sendAction` correctly. | |||
| @@ -33,6 +34,29 @@ export default function componentHook(renderNode, env, scope, _tagName, params, | |||
| let componentCell = stream.value(); | |||
| if (isComponentCell(componentCell)) { | |||
| tagName = componentCell[COMPONENT_PATH]; | |||
|
|
|||
| /* | |||
| * This need to be done to avoid problems with rest positional parameters | |||
There was a problem hiding this comment.
This need to be done to avoid
into
Processing positional params before merging into a hash must be done here to avoid
|
Seems good pending small doc edits :-) |
… syntax As reported in emberjs#12625, positional parameters were not being rendered correctly when using the dot syntax. A longer description on the cause of the problem has been added as a comment to `ember-htmlbars/lib/hooks/component.js` for future warning. Fix emberjs#12625
|
@mixonic I think I've addressed them all |
|
Restarted Sauce |
rwjblue
added a commit
that referenced
this pull request
Nov 19, 2015
[BUGFIX beta] Fix positional params in contextual components with dot syntax
|
thanks @Serabe ! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #12625, positional parameters were not being rendered correctly
when using the dot syntax. A longer description on the cause of the problem has
been added as a comment to
ember-htmlbars/lib/hooks/component.jsfor futurewarning.
Fix #12625