Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Ensure Mixin.prototype.toString is defined. #12636

Commits on Nov 21, 2015

  1. [BUGFIX beta] Ensure Mixin.prototype.toString is defined.

    `Mixin.prototype` is sealed after its initial definition, but
    `Mixin.prototype.toString` is assigned later in `ember-runtime/namespace`.
    This causes issues when `ember-template-compiler.js` is loaded before
    the rest of Ember (because the `Mixin.prototype` is sealed).
    Unfortunately, the debug functions (for `Object.seal`) does not work in
    the `ember-metal` package at this time.
    
    This fix is a temporary fix to allow the loading of
    `ember-template-compiler.js` to be before or after `ember.debug.js`. The
    more permanent fix is to ensure that `debugSeal` works in ember-metal
    properly.
    rwjblue committed Nov 21, 2015
    Configuration menu
    Copy the full SHA
    895bbd7 View commit details
    Browse the repository at this point in the history