[BUGFIX beta] Remove FastBoot monkeypatch #12677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // enabled, we check to see if those flags are on before registering | ||
| // the tests. Once all feature flags are on by default we can remove | ||
| // this conditional. | ||
| if (appModule.canRunTests) { |
There was a problem hiding this comment.
Do we need to keep this around in case it gets backed out?
There was a problem hiding this comment.
I guess so. I'm not sure of the actual process of when things get removed. /cc @rwjblue
|
ProTip™: use https://github.com/emberjs/ember.js/pull/12677/files?w=1 for a better diff 👀 |
tomdale
force-pushed
the
remove-fastboot-monkeypatch
branch
from
75f07b3
to
26d56f2
Compare
|
Looks like this is failing on IE. I don't have a VM on my laptop at the moment, though I'm trying to download one on slow Wi-Fi. If anyone with IE handy could run the tests and report the error, I would appreciate it. |
|
Just a sauce issue, thanks @rwjblue for the re-run. |
The DOM helper used to require a specially patched version of `protocolForURL` and `setMorphHTML` to work in Node. This commit: 1) Adds a test to verify attributes are correctly sanitized in Node 2) Removes the monkeypatches
tomdale
force-pushed
the
remove-fastboot-monkeypatch
branch
from
26d56f2
to
a914541
Compare
tomdale
changed the title
|
Added |
|
Thank you @tomdale |
rwjblue
added a commit
that referenced
this pull request
Dec 8, 2015
[BUGFIX beta] Remove FastBoot monkeypatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DOM helper used to require a patched
protocolForURLto work in Node. This PR:visit()in NodeNote that this PR relies on tildeio/htmlbars#437, which will need to be merged and bumped before this PR's tests will pass.
/cc @chancancode