Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix rerendering contextual components when invoked with dot syntax and block form #12682

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Dec 3, 2015

Block form of components does not use the same hooks as the other invocations.
A bit of preprocessing is needed to invalidate it and cause a rerender.

This fixes #12678

… dot

syntax and in block form

Block form of components does not use the same hooks as the other invocations.
A bit of preprocessing is needed to invalidate it and cause a rerender.

Fixes emberjs#12678
@rwjblue
Copy link
Member

rwjblue commented Dec 3, 2015

LGTM

@mixonic - r?

rwjblue added a commit that referenced this pull request Dec 4, 2015
[BUGFIX beta] Fix rerendering contextual components when invoked with dot syntax and block form
@rwjblue rwjblue merged commit 3f4db6f into emberjs:master Dec 4, 2015
@rwjblue
Copy link
Member

rwjblue commented Dec 4, 2015

Thanks @Serabe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yielded contextual components in block form don't update
2 participants