[BUGFIX beta] htmlsafe warning not thrown for none values #12686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, can you:
|
bekzod
changed the title
bekzod
force-pushed
the
html-safe-none
branch
from
cb7f94a
to
b83f6f8
Compare
bekzod
changed the title
bekzod
force-pushed
the
html-safe-none
branch
from
b83f6f8
to
d3b5185
Compare
|
done :) |
| QUnit.test('null value do not generate htmlsafe warning', function() { | ||
| view = EmberView.create({ | ||
| userValue: null, | ||
| template: compile('<div style={{userValue}}></div>') |
There was a problem hiding this comment.
After re-reviewing, I believe that this (and the other test) need to be tweaked to either use {{view.userValue}} (as it stands this one that is testing undefined also because there is no context of this view).
There was a problem hiding this comment.
thanks for pointing it out, I have corrected that
bekzod
force-pushed
the
html-safe-none
branch
from
d3b5185
to
32e7fee
Compare
|
Awesome, thank you! Sorry for not spotting that last issue in the first review pass. |
rwjblue
added a commit
that referenced
this pull request
Dec 6, 2015
[BUGFIX beta] htmlsafe warning not thrown for none values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed here #12681