[BUGFIX] Remove vestigial path normalization in chains #12929
Conversation
| deprecate( | ||
| `Connecting an Ember.Binding to a global path such as '${this._from}' is deprecated. Please use a service instead.`, | ||
| false, | ||
| { id: 'ember-metal.global-bindings', until: '3.0.0' } |
There was a problem hiding this comment.
Can you please make an entry in the deprecation guide and add a url property here.
There was a problem hiding this comment.
Let's discuss whether we want to deprecate all of Ember.Binding first. I think we should.
There was a problem hiding this comment.
On that note I am going to remove the deprecation from this particular PR.
mmun
force-pushed
the
rm-global-chains
branch
from
73b6aa5
to
59fa972
Compare
mmun
changed the title
|
Kris pointed out a couple other things that should be cleaned up before merging:
And we should do some performance testing to see how much of a win it is. |
|
🔥 🎉 |
Removes support for paths containing globals and "this". These were
intended to be removed at the time when globals support was removeded
from Ember.get/set and from inside of temlates, e.g.
```hbs
{{SomeGlobal.foo}}
```
mmun
force-pushed
the
rm-global-chains
branch
from
59fa972
to
419fc72
Compare
|
Thanks @mmun! |
[BUGFIX] Remove vestigial path normalization in chains
| @@ -219,20 +232,20 @@ Binding.prototype = { | |||
|
|
|||
| /* Called when the from side changes. */ | |||
| fromDidChange(target) { | |||
There was a problem hiding this comment.
this arg doesn't seem one used anymore?
|
This should be documented as breaking but since the behavior made no sense and didn't align with templates I doubt this will bite anyone |
This fixes a bug that occurs when chaining through a property that starts with a capital letter.
Here is a JSBin with a demonstration of the bug.