[BUGFIX beta] Fixes #12899 #12934
Merged
[BUGFIX beta] Fixes #12899 #12934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asakusuma
changed the title
|
Sorry for not getting this done quicker, but thank you for tackling it! |
| containing a mapping of query parameters | ||
| @return {Transition} the transition object associated with this | ||
| attempted transition | ||
| @public |
There was a problem hiding this comment.
Lets land this fix without changing public API (docs here are great, but change @public to @private), then submit a separate documentation only PR that updates?
asakusuma
force-pushed
the
transition-to-fix
branch
from
cad2467
to
0c52064
Compare
Ensure transitionTo returns a transition object. Addresses emberjs#12899
asakusuma
force-pushed
the
transition-to-fix
branch
from
0c52064
to
b1cf8f6
Compare
|
👍 |
|
No problem, @krisselden got me on the right approach |
|
Yeah, he is awesome like that. 😺 I need to determine if this bug is in 2.3.1, and backport to release if it is.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure transitionTo returns a transition object. Addresses #12899