[BUGFIX release] Do not set model on {{render}} rerender #13013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon rerender of the {{render}} helper, the model was set to the value
of the second argument regardless of if there was a second argument.
This means upon rerender a singleton controller would lose its model.
Should be backported to 1.13
rwjblue
added a commit
that referenced
this pull request
Feb 25, 2016
[BUGFIX release] Do not set model on {{render}} rerender
|
Landed in beta (2.4), release (2.3), and release-1-13 (1.13). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon rerender of the {{render}} helper, the model was set to the value of the second argument regardless of if there was a second argument. This means upon rerender a singleton controller would lose its model.
Should be backported to 1.13