[Glimmer2] port {{input}} helper tests #13194
Conversation
|
I've come across a couple of possible bugs with the both are related to having initial values of undefined, so they are edge cases |
|
|
| equal(view.$('input').length, 1, 'A single text field was inserted'); | ||
| }); | ||
|
|
||
| QUnit.test('should become disabled if the disabled attribute is true', function() { |
There was a problem hiding this comment.
moved to @htmlbars Helpers test: {{input}} : @test dynamic attributes
| // this.assertSelectionRange(8, 8); //NOTE: this fails in IE, the range is 0 -> 0 (TEST_SUITE=sauce) | ||
| } | ||
|
|
||
| ['@test specifying `on="someevent" action="foo"` results in a deprecation warning']() { |
There was a problem hiding this comment.
Might need to make sure the event is still fired like the old test.
|
Thanks @GavinJoyce! Just one minor nit but it might not be necessary, will defer to @chancancode, @rwjblue or @krisselden. Also for the things you had to comment out can you potentially create a quest issue that summarizes the issues? 🎆 ✨ 🎉 |
|
☔ The latest upstream changes (presumably e5e6d25) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably 2a2b59a) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -0,0 +1,444 @@ | |||
| import { set } from 'ember-metal/property_set'; | |||
| import TextField from 'ember-templates/components/text_field'; | |||
There was a problem hiding this comment.
please use the helpers, these become const with the flag and we run both @Glimmer and @htmlbars without the flag.
There was a problem hiding this comment.
Just to clarify this should be
import { TextField } from '../../utils/helpers';
|
What needs to happen to get this merged? @chancancode @rwjblue @krisselden |
|
Looks good to me. We need to cleanup those comments in the first few tests, but that doesn't need to block the rest. Can someone make an issue and assign to me to clean up these? |
|
@rwjblue is it just removing them? I could submit a pr. |
|
@btecu - I'd like to better understand why they don't work in IE, and potentially fix that or just disable those assertions in IE. |
Part of #13127
UPDATE: This is ready for review
TODO:
{{input}}on firefox?)nulltests (comment here)