Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Ensure pauseTest runs after other async helpers #13605

Merged
merged 1 commit into from Jun 11, 2016

Conversation

trentmwillis
Copy link
Member

While looking into implementing resumeTest, I noticed that pauseTest didn't seem to be behaving properly (in that it wasn't properly waiting for prior async helpers). I'm unsure why this wasn't registered as an asyncHelper to begin with, but after looking at the repo in the state of the original commit, it looks like some internals of the helpers have changed which probably caused the regression.

@trentmwillis
Copy link
Member Author

Looks like Sauce had a problem on one of the boxes, seems like a fluke.

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 6, 2016

@trentmwillis I kicked sauce

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 6, 2016

@rwjblue @krisselden does this violate semver? If there an issue with changing this from a helper to an async helper?

@rwjblue
Copy link
Member

rwjblue commented Jun 10, 2016

@mixonic - It seems like a clear bugfix to me. The behavior before this change was pretty trolling.

Consider:

test('asdf', function(assert) {
  visit('/');
  click('.blah');
  return pauseTest();
});

The pauseTest executes and returns before visit and click here...

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 11, 2016

👍 seems good

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 11, 2016

@trentmwillis can you flag this [BUGFIX beta] please? Lets roll it as a bugfix and see what happens in beta :-)

@trentmwillis trentmwillis changed the title [BUGFIX] Ensure pauseTest runs after other async helpers [BUGFIX beta] Ensure pauseTest runs after other async helpers Jun 11, 2016
@trentmwillis
Copy link
Member Author

@mixonic sounds good; I've update the commit flag.

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 11, 2016

Thanks @trentmwillis!

@mixonic mixonic merged commit 7559b44 into emberjs:master Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants