Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remainder of outlet tests to new testing setup. #13980

Merged
merged 2 commits into from Aug 15, 2016

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 31, 2016

@rwjblue rwjblue force-pushed the migrate-remainder-of-outlet-tests branch 2 times, most recently from 4589192 to 63bffc0 Compare July 31, 2016 04:01
@rwjblue
Copy link
Member Author

rwjblue commented Jul 31, 2016

Ported tests and updated to ensure templates used in outlet state are all looked up from the owner properly.

@rwjblue
Copy link
Member Author

rwjblue commented Jul 31, 2016

Migrating ember-test-helpers to look templates up from the container in emberjs/ember-test-helpers#168.

@rwjblue
Copy link
Member Author

rwjblue commented Aug 1, 2016

I discussed this a bit with @krisselden, and he wanted me to migrate these this.assertText calls into assertHTML. I tried that but ran into some issues due to the fact that we cannot get access to the id of the top level wrapping component (which makes the assertions fail).

@rwjblue rwjblue force-pushed the migrate-remainder-of-outlet-tests branch from 63bffc0 to ee464a7 Compare August 15, 2016 15:50
@rwjblue rwjblue merged commit d47736c into master Aug 15, 2016
@rwjblue rwjblue deleted the migrate-remainder-of-outlet-tests branch August 15, 2016 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant