Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Avoid assertion when id= is provided to tagless components. #14106

Merged
merged 1 commit into from
Aug 21, 2016

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 21, 2016

Fixes #14105.

@mixonic
Copy link
Sponsor Member

mixonic commented Aug 21, 2016

👍 :shipit: 🙇

@mixonic mixonic merged commit 3ce9336 into emberjs:master Aug 21, 2016
@mixonic mixonic deleted the do-not-assert-on-id branch August 21, 2016 20:41
@krisselden
Copy link
Contributor

Can we at least say people should do this?

@krisselden
Copy link
Contributor

Should not I mean, warn that it won't do anything

@rwjblue
Copy link
Member Author

rwjblue commented Aug 21, 2016

@krisselden - It does not do anything from Ember's perspective, but id is a perfectly valid hash argument (though ambiguous in many cases also) to use for many scenarios where it may be unrelated to id in the DOM.

I guess we could add a deprecation when using id, and folks would just need to come up with better hash argument names...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants