Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix basic component and helper resolution in engines. #14135

Merged
merged 3 commits into from Aug 27, 2016

Commits on Aug 26, 2016

  1. [BUGFIX beta] Clone additional parent dependencies into engine instan…

    …ces.
    
    An engine instance needs to share the following with its parent:
    
    * `service:-glimmer-environment` (only for glimmer)
    * `renderer:-dom` or `renderer:-inert`, depending on whether the environment
      is interactive
    dgeb authored and Robert Jackson committed Aug 26, 2016
    Copy the full SHA
    79026a7 View commit details
    Browse the repository at this point in the history
  2. [BUGFIX beta] Fix basic component and helper resolution in engines.

    Ensure that Cache lookups are performed using the correct owner.
    
    Ensure that engines are destroyed _before_ top-level views so that top-level
    views are not re-instantiated during engine teardown.
    asakusuma authored and Robert Jackson committed Aug 26, 2016
    Copy the full SHA
    447df33 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2016

  1. Use the correct owner for each template lookup.

    Ensure that the owner being used is not the environments default
    `Owner`, but it is the owner that the template is being looked up by.
    
    For late bound templates this means the components owner, and for normal
    templates (looked up from registry) it is passed to the factories
    `.create` method by the container itself.
    Robert Jackson committed Aug 27, 2016
    Copy the full SHA
    02814c2 View commit details
    Browse the repository at this point in the history