[Bugfix beta] Fix DOM output for props and attrs #14315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
fix-props-attrs
branch
3 times, most recently
from
8e592db
to
da67015
Compare
rwjblue
force-pushed
the
fix-props-attrs
branch
from
da67015
to
955f70e
Compare
chadhietala
commented
Sep 19, 2016
| } | ||
|
|
||
| operations.addDynamicAttribute(element, attribute, reference); | ||
| }, | ||
|
|
||
| mapAttributeValue(value) { |
There was a problem hiding this comment.
From what I can tell these were undergoing this normalization twice and would cause issues downstream.
rwjblue
force-pushed
the
fix-props-attrs
branch
from
2bcd1af
to
922c1fd
Compare
This was referenced Sep 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to require glimmerjs/glimmer-vm#319