[BUGFIX beta] Allow boolean values for current-when #14848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the docs say, `A link will be active if current-when is true`. Looks like this might have been broken since 1.13 and emberjs#12344 did not seem to actually fix this particular bug. Related issues: - emberjs#12512 - emberjs#12630 (fix was not merged) - emberjs#12296
whatthewhat
force-pushed
the
link-to-current-when-with-boolean
branch
from
e174b05
to
d0f320a
Compare
|
Rebased and fixed merge conflicts, bump 😉 |
|
Thank you!! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote from the docs for
current-when:But currently using a boolean value produces a TypeError.
Looks like this might have been broken since 1.13 and #12344 did not seem to actually fix this particular issue.
Related issues: #12512, #12630 (fix was not merged), #12296