Deprecate Controller#content alias
#15528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Jul 19, 2017
| @@ -44,6 +44,6 @@ export default Mixin.create(ActionHandler, ControllerContentModelAliasDeprecatio | |||
| /** | |||
| @private | |||
| */ | |||
| content: alias('model') | |||
| content: deprecatingAlias('model') | |||
There was a problem hiding this comment.
This will need an options hash with id, until, description, etc
|
Can you also remove the entry in features.json? |
locks
force-pushed
the
controller-content-mixin
branch
from
db79d4f
to
5d684a7
Compare
|
@rwjblue please re-review and 👀 the commit message for correctness 🙇 |
rwjblue
reviewed
Jul 22, 2017
| @@ -44,6 +44,5 @@ export default Mixin.create(ActionHandler, ControllerContentModelAliasDeprecatio | |||
| /** | |||
| @private | |||
| */ | |||
| content: alias('model') | |||
|
|
|||
| content: deprecatingAlias('model', { id: 'ember-runtime.controller-content', until: '2.16.0' }) | |||
There was a problem hiding this comment.
We also need to add a deprecation guide entry to the website and add a url property with the link.
There was a problem hiding this comment.
deprecation guide PRed: emberjs/website#2969
locks
force-pushed
the
controller-content-mixin
branch
from
5d684a7
to
cb71207
Compare
locks
changed the title
Controller#content alias
locks
force-pushed
the
controller-content-mixin
branch
5 times, most recently
from
8da30d0
to
5705ec5
Compare
So, this is kind of a fun one. From what I can tell, `ControllerContentModelAliasDeprecation` was introduced, due to Controllers having a `content` property, which `model` was aliased to. This was done because `ObjectController` and `ArrayController` were proxying controllers. But, in Ember, routes set up the `model` property of its respective controller. What this meant is that if someone declared a `content` property in their controller, `model` would—seemingly unrelated—break, hence the `ControllerContentModelAliasDeprecation` mixin. Nowadays it is fine to override `content` because the source of truth was reverse, and `model` is now the primary property, being `content` the alias. It is, then, time to remove the old deprecation and instead deprecate the alias itself, so that in the future users can define a `content` property in their controllers if they so desire. Another API bites the dust. Here's to removing yet more code in the future, and make Ember sparkle-clean.
locks
force-pushed
the
controller-content-mixin
branch
from
5705ec5
to
2058272
Compare
rwjblue
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControllerContentModelAliasDeprecation-related code.Controller#contentalias.deprecatingAlias.