Cleanup at end of transaction to prevent memory leaks #15808
Conversation
|
@GavinJoyce - Can you review also? |
There was a problem hiding this comment.
This generally looks good to me, thanks for tackling it! I do find this coding style slightly confusing though (totally a pre-existing issue, and not something new introduced in this PR).
It would go a very long way if we had a comment that explained the general idea of what is going on. Basically documenting the setup, addKey, checkKey, and cleanup functions and how they play into the general transaction system here...
leaks when objects that are rendered are retained. Fix #15803
krisselden
force-pushed
the
fix-double-assert-render-leak
branch
from
811d3ee
to
316c7c6
Compare
|
@rwjblue I think I made the code clearer, it doesn't diff as well, but can you take a look to see if you understand it better now? |
|
This looks good to me (and I agree that the code is now easier to understand) |
|
Thank you @krisselden! This is very much easier for me to understand (and likely better factored too boot). |
|
I believe that this needs to make its way into a 2.16 release once we have vetted it on 2.17 betas... |
Cleanup at end of transaction to prevent memory leaks when objects that are rendered are retained.
Fix #15803