Begin publishing npm tarballs to S3. #16039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will no longer include `-null`.
This is responsible for updating the `package.json` version number (so
that the packed tarball has the same version string as `Ember.VERSION`)
and running `npm pack` to build a tarball suitable for referencing in an
applications `package.json` as:
```js
{
devDependencies: {
"ember-source": "http://builds.emberjs.com/canary.tgz",
}
}
```
In practice, this does not work well enough yet (issues exist for both npm@5 and yarn@1.3 making the "reference github" branch not work properly). This functionality will be replaced with the concept of pointing to prepublished tarballs.
For a single commit to master, would result in the following tarballs: ``` http://builds.emberjs.com/canary.tgz http://builds.emberjs.com/canary/daily/20180101.tgz http://builds.emberjs.com/canary/shas/SOMESHAHERE.tgz ```
With this change, the final version (reported in `package.json` and `Embrer.VERSION`) for canary builds will be `3.0.0-canary+SHAHERE` and for alpha builds it would be `3.0.0-alpha+SHAHERE`. For tagged builds, the tag itself is what will be used (minus any `v` prefix).
mixonic
reviewed
Jan 1, 2018
| @@ -5,11 +5,8 @@ echo -e "PULL_REQUEST: ${TRAVIS_PULL_REQUEST}\n" | |||
|
|
|||
| if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "$PUBLISH" == "true" ]; then | |||
|
|
|||
| if [ "$EMBER_ENV" != "production" ]; then | |||
| DISABLE_JSCS=true DISABLE_JSHINT=true ember build --environment=production | |||
There was a problem hiding this comment.
yarn build seems to replace this, however yarn build does not DISABLE_JSCS=true DISABLE_JSHINT=true, if I read this correctly.
Is this something to be addressed?
There was a problem hiding this comment.
Yes, but the fix is to remove all references to DISABLE_JSCS and DISABLE_JSHINT in other files...
Basically, they were environment variables that emberjs-build was aware of and made special, but since we migrated away from emberjs-build (sometime before Ember 2.10?) they no longer have meaning.
mixonic
approved these changes
Jan 1, 2018
This reverts commit d76312c. `prepare` script was removed, so we need to bring this back...
rwjblue
added a commit
to rwjblue/ember.js
that referenced
this pull request
Jan 2, 2018
This was identified in the review of emberjs#16039.
This was referenced Jan 2, 2018
|
This has been backported to beta and release channels as well... |
lorcan
pushed a commit
to lorcan/ember.js
that referenced
this pull request
Feb 6, 2018
This was identified in the review of emberjs#16039.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally allows us to easily consume and test alpha, canary, beta, and release channels with
ember-sourceas annpmdependency (previously to use these channel specific builds you must use them viabower).For example, to use the canary channel from an app (or addon) after this lands you would have the following in your
package.json:The following assets are published for each channel (using
canaryfor illustrative purposes, but the same paths are available for each):Once this lands, we can begin removing bower and globals build publishing infrastructure...