Move each proxy into a weak map #16215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 5, 2018
| this.__each = new EachProxy(this); | ||
| } | ||
| deprecate( | ||
| "Getting the '@each' property is deprecated", |
There was a problem hiding this comment.
The message needs to include more details, or it’s going to be very hard to track down...
|
|
||
| return this.__each; | ||
| return meta(this).eachProxy; | ||
| }).volatile().readOnly() |
There was a problem hiding this comment.
I can’t recall, why is this volatile (seems like it is stable based on the implementation)?
There was a problem hiding this comment.
I don't know exactly why it was volatile, but it certainly doesn't need to be now (in fact, we could remove this CP if we wanted).
mmun
force-pushed
the
move-each-proxy-to-meta
branch
from
6b10d12
to
2a2a6fd
Compare
|
In chat, Rob suggested I move the each proxy into a weakmap rather than meta. I will do this. |
mmun
force-pushed
the
move-each-proxy-to-meta
branch
from
2a2a6fd
to
97c7080
Compare
... and fix some tests that should ahve been testing the method version of objectAt.
mmun
force-pushed
the
move-each-proxy-to-meta
branch
from
97c7080
to
00a7488
Compare
|
@rwjblue Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geting@each. I am treating this as an intimate private API.objectAtinto ember-metal to avoid ember-metal depending on ember-runtime.array.objectAt(i)instead ofobjectAt(array, i).Remaining items: