extract uniqBy as generic method and reuse internally
#16567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
force-pushed
the
uniq-by
branch
3 times, most recently
from
7a77e71
to
c37812c
Compare
mmun
reviewed
Apr 22, 2018
packages/ember-runtime/lib/utils.js
Outdated
|
|
||
| let ret = A(); | ||
| let seen = new Set(); | ||
| let getter = arguments.length === 1 ? item => item : get; |
There was a problem hiding this comment.
can you do something like
const identityFunction = item => item;
export function uniqBy(array, key = identityFunction) {
|
green |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmun is this worth doing ? 馃槈