move WeakSet polyfill to @ember/polyfills
#16990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Sep 20, 2018
packages/@ember/polyfills/index.ts
Outdated
| @@ -5,4 +5,5 @@ let merge = MERGE ? deprecatedMerge : undefined; | |||
|
|
|||
| // Export `assignPolyfill` for testing | |||
| export { default as assign, assign as assignPolyfill } from './lib/assign'; | |||
| export { default as WeakSet } from './lib/weak_set'; | |||
There was a problem hiding this comment.
The @ember/polyfills package does not intend to have this as public API, can you export it as an underscored property?
bekzod
force-pushed
the
move-weak-set
branch
from
04fbecc
to
e6e0dee
Compare
bekzod
force-pushed
the
move-weak-set
branch
from
e6e0dee
to
519a698
Compare
rwjblue
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is more appropriate to have it under
@ember/polyfillsI think