Router.js Generics & Route Infos Prep Work #17007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csantero
reviewed
Sep 25, 2018
| Object.defineProperty(transition.state, 'handlerInfos', { | ||
| get() { | ||
| deprecate( | ||
| 'You attempted to use "transition.state.handlerInfos" which is a private API that will being removed.', |
There was a problem hiding this comment.
will being should say will be.
chadhietala
force-pushed
the
router-service
branch
3 times, most recently
from
96f8e6f
to
0d222b6
Compare
rwjblue
reviewed
Sep 27, 2018
| return this; | ||
| } | ||
|
|
||
| const { slice } = Array.prototype; | ||
|
|
||
| const DEPRECATION_MAP = new WeakMap(); | ||
|
|
||
| function deprecatedTransition(transition: Transition) { |
There was a problem hiding this comment.
This should be wrapped for svelting...
|
|
||
| function deprecatedTransition(transition: Transition) { | ||
| if (transition.state) { | ||
| Object.defineProperty(transition.state, 'handlerInfos', { |
There was a problem hiding this comment.
Can we reach in and define this on the base class instead of for each transition?
| class PrivateRouter extends Router { | ||
| class PrivateRouter extends Router<Route> { | ||
| get currentHandlerInfos() { | ||
| deprecate( |
| getHandler(name: string) { | ||
| deprecate( |
chadhietala
force-pushed
the
router-service
branch
from
0d222b6
to
d91a4d0
Compare
chadhietala
force-pushed
the
router-service
branch
2 times, most recently
from
54e9ac2
to
528a0ec
Compare
rwjblue
approved these changes
Oct 1, 2018
| @@ -331,7 +332,7 @@ class Route extends EmberObject { | |||
| @method _reset | |||
| @since 1.7.0 | |||
| */ | |||
| _reset(isExiting: boolean, transition: Transition) { | |||
| reset(isExiting: boolean, transition: Transition) { | |||
There was a problem hiding this comment.
Seems like this is still private, why is the underscore removed? Also, shouldn't we be worried about userland naming collisions?
chadhietala
force-pushed
the
router-service
branch
from
528a0ec
to
55bd846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls router.js's generics through Ember's router. It simultaneously introduces the concept of
RouteInfo.RouteInfois what we typically calledHandlerInfo. While this was a private API we leaked it out indid|willTransitionhooks. Because of that it effectively became intimate API. To compensate for this I have added deprecations around the following private apis_routerMicrolib.currentHandlerInfos_routerMicrolib.getHandlertransition.handlerInfostransition.state.handlerInfoshandlerInfos[0].handlerThis is based on the usage from EmberObserver
There is going to be a quick follow that is going to expose
transition.toandtransition.fromalong with therouteWillChangeandrouteDidChangeevents as described by Router Service RFC