Update broccoli-uglify-sourcemap to v2.2.0
#17275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general the |
rwjblue
approved these changes
Dec 6, 2018
|
okaaaay... then... why do we generate it? 😅 |
|
Why not!?!?!!? |
|
because it takes time to build it 😉 |
|
yeah, but its CI time so..... |
|
(note: I do agree with you) |
Turbo87
added a commit
to Turbo87/ember.js
that referenced
this pull request
Dec 6, 2018
According to emberjs#17275 (comment) the `ember.min.js` asset is not being used anymore. This commit removes the asset from the build pipeline, since the uglify step takes a significant amount of time.
Turbo87
added a commit
to Turbo87/ember.js
that referenced
this pull request
Dec 7, 2018
According to emberjs#17275 (comment) the `ember.min.js` asset is not being used anymore. This commit removes the asset from the build pipeline, since the uglify step takes a significant amount of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat significant change as we are now using
terserunder the hood, instead ofuglify-js/es. On first glance, the slightly changed output looks alright, but this should probably be verified a little more thoroughly.