[BUGFIX beta] fix 'strict mode does not allow function declarations' #17426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discovered that on ios9 (at least) there is an error
strict mode does not allow function declarationswhich prevents the application to work normally. We assume, although we're not quite sure, it was released with the v3.6.Anyways, it's related to the fact that the function
cleanURLwas declared within anifblock in therouter.ts.It turns out that the eslint rule which cares about such issues had been disabled. After re-enabling it I found out that there are only 2 issues (the one with the router and another one in the test).
I guess it's worth making the rule enabled; I also fixed the 2 failures by assigning functions to variables.