Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Update to glimmer-vm 0.37.1. #17499

Merged
merged 4 commits into from Jan 22, 2019

Conversation

Projects
None yet
5 participants
@rwjblue
Copy link
Member

commented Jan 22, 2019

Fixes a few issues:

  • Usage of positional arguments with custom components.
  • Forwarding attributes via ...attributes to a dynamic
    component.
  • Prevent errors when rendering many template blocks
    (Error: Operand over 16-bits. Got 65536).

Full changes here:

glimmerjs/glimmer-vm@v0.37.0...v0.37.1


Closes #17146
Closes #17160
Closes #17483

@rwjblue rwjblue force-pushed the rwjblue:patch-glimmer-vm branch from d0c04d1 to b807746 Jan 22, 2019

rwjblue and others added some commits Jan 22, 2019

[BUGFIX beta] Update to glimmer-vm 0.37.1.
Fixes a few issues:

* Usage of positional arguments with custom components.
* Forwarding attributes via `...attributes` to a dynamic
  component.
* Prevent errors when rendering many template blocks
  (`Error: Operand over 16-bits. Got 65536`).

Full changes here:

glimmerjs/glimmer-vm@v0.37.0...v0.37.1
[BUGFIX beta] Add failing test for yielding inside a contextual compo…
…nent invoked with angle-bracket syntax that receives splattributes

(cherry picked from commit 2d1f8d0)

@rwjblue rwjblue force-pushed the rwjblue:patch-glimmer-vm branch from b807746 to 9ce961a Jan 22, 2019

@rwjblue rwjblue changed the title Update to glimmer-vm 0.37.1. [BUGFIX beta] Update to glimmer-vm 0.37.1. Jan 22, 2019

@rwjblue rwjblue merged commit 3a8b530 into emberjs:master Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue deleted the rwjblue:patch-glimmer-vm branch Jan 22, 2019

@rwjblue

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2019

FYI - These changes landed in:

  • 3.4.8 (released today)
  • 3.7.2 (released today)
  • 3.8.0-beta.3 (should be released 2019-01-28)
@jamescdavis

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

Yay, dynamic component splattributes! Thanks, @rwjblue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.