Backport Glimmer VM upgrade + bugfixes to release #17884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@glimmer/* 0.37.1 -> 0.38.1 typescript 3.0.1 -> 3.2.4 (cherry picked from commit bfa97c8)
wycats
force-pushed
the
upgrade-glimmer-release
branch
from
874855a
to
da2307a
Compare
This is needed due to https://github.com/glimmerjs/glimmer-vm/blob/e672233ea70ab2614648bb194efc107f3698baad/packages/%40glimmer/runtime/lib/compiled/opcodes/component.ts This is probably unintended and a waste of bytes. We should fix it upstream and remove this helper. (cherry picked from commit fd360ca)
When a `class=` attribute comes _after_ `...attributes`, we don't merge it correctly. Instead it gets clobbered. This PR adds failing tests. (cherry picked from commit a2b0e72)
wycats
force-pushed
the
upgrade-glimmer-release
branch
from
2991c46
to
9173312
Compare
rwjblue
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glimmer/* 0.37.1 -> 0.38.1
typescript 3.0.1 -> 3.2.4
(cherry picked from commit bfa97c8)