Add deprecations for mouseEnter/Leave/Move Ember events #18214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
rwjblue
reviewed
Jul 25, 2019
There was a problem hiding this comment.
Looking really good!
A few small things:
- Ensure there is a test for
<div {{action 'foo' on={{this.mouseMethod}}></div>? - Can we avoid adding these listeners when we do not detect the deprecated situations? Maybe I should modify my other PR to be limited to just these three events (so we can more easily land it)?
|
|
||
| deprecate( | ||
| `Using the \`{{action}}\` modifier with \`${actionState.eventName}\` events has been deprecated.`, | ||
| actionState.eventName !== 'mouseEnter' && |
There was a problem hiding this comment.
I'm a tad worried about:
Do we have a test for that? Does it also emit the deprecation warning?
There was a problem hiding this comment.
Seems reasonable to me! (for others, we are talking about #17911) Either way I think we can/should do it as a separate PR, as this is just concerned about the deprecations, and the other is about optimizations. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC486