[BUGFIX release] Ensure loader.js is transpiled via targets.
#18582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
approved these changes
Nov 26, 2019
Prior to this change, the `packages/loader/lib/index.js` file was not transpiled (at all). However, until 4a5b372 landed the file was still authored (manually) in IE11 compliant ES5 JavaScript. Once 4a5b372 landed however (first released in 3.14.0-beta.1) it is impossible to use the built assets in a browser that does not support `let` variable declaration (e.g. Safari 9). This ensures that `packages/loader/lib/index.js` passes through the same transpilation process as the rest of the application, and (confirmed manually) fixes the issue reported. Ironically, our CI did not catch this issue (even though we are properly testing in IE11) because IE11 actually supports `let` usage (with minor caveats). Also, since `loader.js` is the "one thing" that does not need modules transpilation, this also adds a new argument to `transpileTree`. Most of the time that option is `undefined` (and therefore not used at all), but for header files we need to avoid the module wrapping.
rwjblue
force-pushed
the
fixup-loader-transpilation
branch
from
204cdc8
to
60b8dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the
packages/loader/lib/index.jsfile was not transpiled (at all). However, until #18277 landed the file was still authored (manually) in IE11 compliant ES5 JavaScript. Once #18277 landed however (first released in 3.14.0-beta.1) it is impossible to use the built assets in a browser that does not supportletvariable declaration (e.g. Safari 9).This ensures that
packages/loader/lib/index.jspasses through the same transpilation process as the rest of the application, and (confirmed manually) fixes the issue reported in ember-cli/ember-cli#8938.Ironically, our CI did not catch this issue (even though we are properly testing in IE11) because IE11 actually supports
letusage (with minor caveats).Fixes ember-cli/ember-cli#8938