[BUGFIX lts] More assertions for Application lifecycle methods #18960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
application-assertions
branch
from
a078de8
to
4e2049f
Compare
|
...seems like this broke many things 😅 |
rwjblue
requested changes
May 9, 2020
| @@ -516,7 +526,7 @@ const Application = Engine.extend({ | |||
| @method domReady | |||
| */ | |||
| domReady() { | |||
| if (this.isDestroyed) { | |||
| if (this.isDestroying || this.isDestroyed) { | |||
There was a problem hiding this comment.
FWIW, once we go this.isDestroying = true we never change it again. I think checking both makes the code easier to read (and avoids everyone having to internalize that particular detail) but I don't think it is actually going to change anything about the semantics.
While debugging an issue in the ember-inspector test harness, we eventually we were dealing with very subtle hanging and errors that were ultimately caused by trying to boot an already destroyed `Application`. The issue was very difficult to debug partly due to some states (like `_bootPromise`) was reset in `willDestroy`, which is not necessary, but was enough to cause other lifecycle methods (like `boot`) to happily restart the process, but just hangs forever later on. This removes the state reset form `willDestroy` and just adds a lot more assertions in general, hopefully making these kind of situations fail louder and earlier.
chancancode
force-pushed
the
application-assertions
branch
from
4e2049f
to
9ea4376
Compare
rwjblue
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue in the ember-inspector test harness, we eventually we were dealing with very subtle hanging and errors that were ultimately caused by trying to boot an already destroyed
Application.The issue was very difficult to debug partly due to some states (like
_bootPromise) was reset inwillDestroy, which is not necessary, but was enough to cause other lifecycle methods (likeboot) to happily restart the process, but just hangs forever later on.This removes the state reset form
willDestroyand just adds a lot more assertions in general, hopefully making these kind of situations fail louder and earlier.