[BUGFIX release] Adds isProduction flag for the template compiler #19081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
bugfix/production-template-compiler
branch
from
d03722f
to
b05058e
Compare
pzuraq
changed the title
…ent. This allows us to thread through custom options and have them be typed properly (e.g. `env.meta` no longer needs to be cast to `StaticTemplateMeta`).
rwjblue
force-pushed
the
bugfix/production-template-compiler
branch
from
b05058e
to
0cbf985
Compare
|
@pzuraq - I pushed an updated implementation, this should be ready for another look... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
isProductionflag option to the template compiler that can be used to change the behavior of the compiler for production builds. We generally do this already for the JS side of Ember, but not for templates, and this closes that gap.Notes:
Exposes an
env.isProduction(or for legacy style AST pluginsthis.options.isProduction) boolean that can be used from within the plugin itself to toggle debug vs prod only behaviors.Fixes #18598