[Deprecation] renderTemplate and disconnectOutlet methods
#19388
Conversation
patocallaghan
force-pushed
the
patoc/rfc-491-418
branch
from
343d4cc
to
0635802
Compare
|
There was another draft PR #19187, seems good for you to take over but you may find it helpful to reference that. |
|
Thanks @chancancode! I'll do that 🙇♂️ |
| deprecate('The usage of `disconnectOutlet` is deprecated.', false, { | ||
| id: 'router-render-methods.disconnect-outlet', | ||
| until: '4.0.0', | ||
| url: 'TODO', |
There was a problem hiding this comment.
Should be auto-deployed shortly, so you can grab the URL
| url: 'TODO', | ||
| for: 'ember-source', | ||
| since: { | ||
| enabled: '3.26.0', |
There was a problem hiding this comment.
| enabled: '3.26.0', | |
| enabled: '3.27.0', |
There was a problem hiding this comment.
@rwjblue so isn't the current beta cycle 3.26 when we'd expect this to land?
There was a problem hiding this comment.
So, beta has already branched away from master. This happens 6 weeks before the beta is released. During those 6 weeks, when we land features on master, they are not by default included in beta - they are targeting the release after beta (e.g. canary).
We can, and sometimes do, patch them into the beta branch (e.g. for bugfixes). For features and deprecations, we approach it on a case-by-case basis, but we tend to avoid it unless there is a good reason and it's not a high risk change. In this case, I think it's reasonable to not backport, so we would be targeting master, which is currently 3.27.0.
There was a problem hiding this comment.
I've decided to break the disconnectOutlet deprecation out into #19407. The render and renderTemplate deprecations are taking longer than I expected (lots of tests to fix).
|
@patocallaghan - Where are we at with this one? |
|
@rwjblue this can be closed now. Thanks! |
Deprecates
renderTemplate(RFC 418) anddisconnectOutlet(RFC 491)Taken from the Deprecations list
Task list
renderTemplateThe usage of 'renderTemplate' is deprecated. Please see the following deprecation guide to migrate.route-render-methodsdeprecatedisconnectOutlet"The usage of 'disconnectOutlet' is deprecated. Please see the following deprecation guide to migrate.disconnect-outletdeprecate/cc @locks