Refactor router: remove owner presence checks #19458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 Unless I miss somehing, fhe failing browserstack tests do not seem related to this. |
Ya, this is intentional. There are a number of scenarios where we only want to do partial setup. For example, in rendering tests (for a normal ember-cli project) we might want to render |
rwjblue
approved these changes
Mar 12, 2021
Comment on lines
-45
to
-49
| ['@test can create a router without an owner'](assert) { | ||
| createRouter(undefined, { disableSetup: true, skipOwner: true }); | ||
|
|
||
| assert.ok(true, 'no errors were thrown when creating without a container'); | ||
| } |
There was a problem hiding this comment.
This test is very odd, 👍 on removing
sly7-7
force-pushed
the
remove-router-owner-check
branch
from
2bb231a
to
537c34f
Compare
rwjblue
approved these changes
Mar 12, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwjblue This follows the discussion we had about this.
That way, I think it removes a useless small mental overhead.
Also as it was a concern only in tests, I think it's better.
Feedback welcome :)
To go a little further, I was wondering if the setupRouter() thing could be removed too ?
Maybe it's by design, but usually it feels wrong to me when there is such a 'two steps construction' before we can actually interact with an instance.