[BUGFIX LTS] Prevent transformation of block params called attrs
#19472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the `transform-attrs-into-args` transform plugin from transforming block params that are named "attrs" and are yielded by components.
|
Naming things is not my strongest skill and I'm not sure if I'm using the correct terms, so do let me know if I need to change / rewrite some sentences somewhere! |
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the
transform-attrs-into-argstransform plugin from transforming block params that are named "attrs" and are yielded by components.The following snippet would render nothing before this change even though a value was yielded from the component template: