Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] pass module prefix to initializer test blueprints #19542

Merged
merged 1 commit into from
May 24, 2021

Conversation

anehx
Copy link
Contributor

@anehx anehx commented May 12, 2021

This fixes this issue with a newly generated (instance) initializer test:

Error: Assertion Failed: `modulePrefix` must be defined

This issue was introduced in fa35230

@anehx anehx force-pushed the fix-initializer-test-blueprints branch from 718a705 to 481f5ca Compare May 12, 2021 07:42
@anehx anehx changed the title fix(blueprints): pass module prefix to initializer test blueprints BUGFIX blueprint] pass module prefix to initializer test blueprints May 12, 2021
@anehx anehx force-pushed the fix-initializer-test-blueprints branch from 481f5ca to 159c3a2 Compare May 12, 2021 07:48
@anehx anehx force-pushed the fix-initializer-test-blueprints branch from 159c3a2 to c69365b Compare May 12, 2021 07:53
@anehx anehx changed the title BUGFIX blueprint] pass module prefix to initializer test blueprints BUGFIX] pass module prefix to initializer test blueprints May 12, 2021
@anehx anehx changed the title BUGFIX] pass module prefix to initializer test blueprints [BUGFIX] pass module prefix to initializer test blueprints May 12, 2021
@anehx
Copy link
Contributor Author

anehx commented May 19, 2021

Anything I can do to push this forward?

@rwjblue rwjblue changed the title [BUGFIX] pass module prefix to initializer test blueprints [BUGFIX beta] pass module prefix to initializer test blueprints May 24, 2021
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @anehx!

@rwjblue rwjblue enabled auto-merge May 24, 2021 14:52
@rwjblue rwjblue merged commit 6d6d43f into emberjs:master May 24, 2021
@anehx anehx deleted the fix-initializer-test-blueprints branch May 25, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants