Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renderTemplate, disconnectOutlet, render #19659

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

mixonic
Copy link
Sponsor Member

@mixonic mixonic commented Jul 19, 2021

Removing these features also effectively removes support for named outlets, however I did not update the docs or code to prevent a name from being passed to {{outlet 'foo'}} as it was not explicitly deprecated.

Per #19617

@mixonic mixonic mentioned this pull request Jul 19, 2021
58 tasks
@mixonic mixonic force-pushed the mixonic/remove-renderTemplate branch from 96f0fd3 to 7f1513c Compare July 21, 2021 01:02
Removing these features also effectively removes support for named
outlets.
@mixonic mixonic force-pushed the mixonic/remove-renderTemplate branch from 7f1513c to 8547049 Compare July 21, 2021 01:20
@mixonic mixonic marked this pull request as ready for review July 21, 2021 01:33
@rwjblue rwjblue merged commit cc45f94 into emberjs:master Jul 21, 2021
@rwjblue rwjblue deleted the mixonic/remove-renderTemplate branch July 21, 2021 15:33
@mixonic
Copy link
Sponsor Member Author

mixonic commented Jul 31, 2021

The comment here around {{outlet 'foo'}} being dropped as API was discussed on July 23rd with Ember Framework Core. We agreed that {{outlet 'foo'}} should become an assertion in dev builds. In a production build, 'foo' is an argument passed where {{outlet}} would expect none, and so it would be silently ignored. Asserting in dev will prevent users who expect an argument here from stumbling into an unexpected behavior.

edit: Implemented at #19691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants