Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isExternal argument to simplify ember-engines #20151

Conversation

BobrImperator
Copy link

  • Adds isExternal argument to LinkTo component
    • based on the flag it disables assertions that are causing Routeless engines to fail, ember-engines internally overrides them.
    • based on the flag, it changes the behavior of namespaceRoute method, so it uses the provided route directly without changing it further - in that case ember-engines is responsible for passing correctly resolved routes.

@SergeAstapov
Copy link
Contributor

@BobrImperator FYI this contradicts the long term and more stable solution proposed in emberjs/rfcs#819

@kategengler
Copy link
Member

Closing since it contradicts the RFC

@BobrImperator BobrImperator deleted the bobrimperator-add-is-external-argument branch December 12, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants