[DOC] Improve didTransition in routing #20333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
requested changes
Jan 23, 2023
olenderhub
force-pushed
the
docs/routing/didTransition
branch
from
8105622
to
809a9eb
Compare
|
@chriskrycho thank you for the clarification. I misunderstood this. I removed what you mentioned in the comment and pushed by force code related to removing the old approach. |
chriskrycho
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
this.controller.get('errors.base').clear();breaks https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-controller-access-in-routes.md rule.didTransitionthis way is deprecated in favor of https://deprecations.emberjs.com/v3.x/#toc_deprecate-router-events