Store Router.location in container. #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested in emberjs#3702, but since that PR targeted the beta branch we decided not to make significant structural changes. This enables the location to be looked up from the container (instead of manually created). Deprecates usage of `Ember.Location.registerImplementation`.
|
cc @tomdale |
stefanpenner
added a commit
that referenced
this pull request
Nov 26, 2013
Store Router.location in container.
rwjblue
added a commit
to rwjblue/ember.js
that referenced
this pull request
Dec 12, 2013
The refactoring in emberjs#3752 caused the rootURL to not be passed at initialization time to the location implementation. This change reverses that by injecting the `router:main` into the newly created location instance. The tests were also refactored: * Split HistoryLocation tests out from the router basic tests. * Ensure that we are testing the right thing in router tests (ensuring that the rootURL is available to the location implementation). * Fixed issue with existing rootURL check that made the test pass due to the fact that the default rootURL (`/`) just happens to be the rootURL while running the test via `rackup`. Resolves: emberjs/ember-dev#115
rwjblue
added a commit
that referenced
this pull request
Dec 20, 2013
The refactoring in #3752 caused the rootURL to not be passed at initialization time to the location implementation. This change reverses that by injecting the `router:main` into the newly created location instance. The tests were also refactored: * Split HistoryLocation tests out from the router basic tests. * Ensure that we are testing the right thing in router tests (ensuring that the rootURL is available to the location implementation). * Fixed issue with existing rootURL check that made the test pass due to the fact that the default rootURL (`/`) just happens to be the rootURL while running the test via `rackup`. Resolves: emberjs/ember-dev#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested in #3702, but since that PR targeted the beta branch we decided not to make significant structural changes.
This enables the location to be looked up from the container (instead of manually created).
Deprecates usage of
Ember.Location.registerImplementation.Resolves #3803.