[BUGFIX beta] Add preventDefault option to link-to and action. #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2013
| handled internally and we do not want to take the browser to a new URL (for | ||
| example). | ||
|
|
||
| If you need to override this behavior specifiy `preventDefault=false` in |
There was a problem hiding this comment.
Good catch, fixed in 35a85d4.
|
+1 |
|
@rjackson Can you rebase this so we can get the tests to pass? Thanks! |
|
@wagenet - Rebased! |
|
@wagenet - Failure on beta run is due to gemfile mismatch between beta and master. I can update ember-dev to ensure that |
|
@rjackson I can merge this manually for now, but it wouldn't hurt to update ember-dev to prevent this in the future. |
|
@wagenet - DONE: emberjs/ember-dev#111. Next time we update ember-dev in the Gemfile.lock we'll pull this in. |
|
@wagenet - The changes from emberjs/ember-dev#111 have been pulled in now, and this has been rebased. Should be good now. |
wagenet
added a commit
that referenced
this pull request
Dec 9, 2013
[BUGFIX beta] Add preventDefault option to link-to and action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3737