Allow reuse of Application.buildContainer without full Application. #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow usage of `Ember.Application.buildContainer` without needing providing a namespace (or an Ember.Application instance). The primary impetus of this is to prevent from having to create one-off container look-alikes for unit testing. This also allows us to consolidate the knowledge of what things are registered and setup by default to a single place.
| container.set = Ember.set; | ||
| container.resolver = resolverFor(namespace); |
There was a problem hiding this comment.
I can imagine wanting to use a resolver for unit tests
There was a problem hiding this comment.
Then you would simply have to provide a namespace.
|
I acknowledge a problem exists here, I am unsure if this is the solution though. I need to think on this some more. |
|
No worries, I'd be happy to work out a better solution. Let me know if you have any suggestions/ideas to make the situation better. |
|
ya, i'll try to grind out some ideas. |
|
I definitely, think that we need an easily discoverable way to know the options for given types. Here are a couple more ideas:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow usage of
Ember.Application.buildContainerwithout needing providing a namespace (or an Ember.Application instance).The primary impetus of this is to prevent from having to create one-off container look-alikes for unit testing. This also allows us to consolidate the knowledge of what things are registered and setup by default to a single
place.
This will be directly usable from within EAK (see isolatedContainer) for example.