Add size and maxlength to Ember.TextSupport #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgeb does |
|
Good catch. I'll modify this PR. |
|
@wagenet Just updated. TextField gets maxlength and size. TextArea gets maxlength, rows and cols. And both get tests :) |
|
@dgeb mind rebasing? |
|
@wagenet rebasing complete - let me know if I can neaten anything up further. |
|
@dgeb whoops, I should have been more specific. I was thinking that it would be nice if you could squash this into a single commit. |
…nd cols to TextArea
|
@wagenet I think it's all set now. |
wagenet
added a commit
that referenced
this pull request
Feb 29, 2012
Add size and maxlength to Ember.TextSupport
sandstrom
pushed a commit
to sandstrom/ember.js
that referenced
this pull request
Jun 17, 2021
Simplify default serializer deprecation docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.