[BUGFIX beta] IE8 fixes for beta #5609
Conversation
| @@ -3,9 +3,9 @@ import { Renderer } from "ember-metal-views"; | |||
| var renderer; | |||
|
|
|||
| function MetalRenderer () { | |||
| MetalRenderer.super.call(this); | |||
| MetalRenderer._super.call(this); | |||
There was a problem hiding this comment.
can we do the fast no-rebind + inline version of this?
function MetalRenderer() {
this._super$constructor();
}
MetalRenderer.prototype._super$constructor = RendererThere was a problem hiding this comment.
This is a test helper, not even a lukewarm path. I'd like to lean toward the least surprising thing in this case. If this is a pattern that would be good to adapt across the board for internals I can make a big patch for it over the codebase
|
Refactored to avoid calling morph creation helpers with the contextual element in addition to the parent (which is likely the contextual element), except where required. This meant making the morph creation helpers fail harder and faster. I'm happy with the tradeoff. Rebased and down to five failures: The first three of which are something obscured by |
| @@ -46,6 +46,9 @@ all the tests by not specifying a `package` param: | |||
| You can also pass `jquery=VERSION` in the test URL to test different | |||
| versions of jQuery. | |||
|
|
|||
| To run the tests in a browser that requires ES3 recast (IE8), you must | |||
There was a problem hiding this comment.
npm start (which is the documented way to run a test server) and npm run build (the documented way to build) runs in the production environment already.
Do we need to add/change this?
There was a problem hiding this comment.
we could probably add npm run-script production-server
There was a problem hiding this comment.
lgtm. dropped this commit.
|
What what metal-views is passing IE8? Cats and dogs living together? Free sundae with with the daily special? Only Travis stands alone in defiance of my failure-crushing drive. Running with with extra verbosity here: |
mixonic
force-pushed
the
ie8
branch
2 times, most recently
from
d652a13
to
0707b90
Compare
Also bumps HTMLBars. During a renderTree call, look to the morphs for information about the contextualElement. Pass this to the Ember renderer, which in turn passes it to the buffer for use when generating an element. Additionally, strip omitted start tags even if the child node causing their generation is after a script tag. See the long comment in `render_buffer`.
|
I believe travis is failing because of the second commit here, the test cleanups. I've seen the first commit build successfully a few times. For example. Trying it again with a force push. |
|
Looks good to me, and Travis is green. 🤘 |
[BUGFIX beta] IE8 fixes for beta
6 failures left to go. Everything major seems to be locked down, though this also requires that tildeio/htmlbars#91 be merged and the dependency in Ember be updated.
Review of this and the HTMLBars PR very welcome.