Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workaround for #5606] o_0) iOS 8 non-64bit Object.create bug... #5629

Closed
wants to merge 1 commit into from

Conversation

stefanpenner
Copy link
Member

ghetto hack for #5606 – o_0) that is all

  • properly analyze what is unique about Nested #each on iOS8 #5606 to better understand this issue
  • after ^^ try to isolate and report the issue to apple as it does appear unique to other similar issues
  • think about this when I'm not tired (in the morning)
  • sanity check with others ( @krisselden et al i could use some cycles)
  • release 1.7.1 (maybe more?)
  • release new beta or get something into canary

other issues that have popped up turn out to be slightly different, an example of there test is attached bellow but it seems to cause issues for all Safari 8 Versions and platforms, whereas ours seems to only affect some devices.

see: #5606 for more details (I will continue to flesh this out after I sleep)

a more accurate test for something similar... they symptoms are so close i assume it is the same problem, but our scenario is different. But maybe it is a better check?

this test needs 'use strict' and the parentClass to be window.HTMLElement.prototype maybe our scenario touches a native object as well?

function test() {
  var broken;
  (function(){
    "use strict";
    var proto = Object.create(window.HTMLElement.prototype);
    try { 
      proto.constructor = function () {
      };

      broken = false;
    } catch(e) {
      broken = true;
    }
  }());

  return broken;
}

@toranb
Copy link
Contributor

toranb commented Sep 24, 2014

@stefanpenner I just wanted to drop a quick "thank you" for all the hard work you've put into this! You always seem to be one step ahead of me on these interesting bugs - for this and all your other OSS work - thank you, thank you, thank you !!!

@ghedamat
Copy link
Contributor

@toranb I could not agree more!!! Thanks @stefanpenner

kenkouot pushed a commit to kenkouot/ember that referenced this pull request Sep 26, 2014
@stefanpenner
Copy link
Member Author

https://github.com/kenkouot/ember is a mirror of this patch

@chrisvariety
Copy link
Contributor

Huge props to @stefanpenner for figuring this out, and just rocking it. 🤘 Bit by this in our own app and I spent a while digging through the Ember source to see if I could monkeypatch it myself, but quickly grew out of my depth. Leave it to the ember.js Thought Leaders™

@eviltrout
Copy link
Contributor

I just wanted to say I love you @stefanpenner !!!

@stefanpenner
Copy link
Member Author

@eviltrout thanks :)

I'm absolutely out of bandwidth this week, but we need to

  • report this bug
  • try to reduce the problem (if possible)
  • maybe the reduced problem will provide a better detection mechanism
  • pray this problem doesn't manifest in other ways and in other places

I'm unsure if you or someone in the community has time, but I could use the help on ^^.

cc @twokul

@twokul
Copy link
Member

twokul commented Sep 26, 2014

@stefanpenner I'll take a look at it today, updating view helpers PR atm

@simi
Copy link
Contributor

simi commented Sep 26, 2014

I think it is reported already (https://bugs.webkit.org/show_bug.cgi?id=49739).

@stefanpenner
Copy link
Member Author

@simi I believe this is different, we (as far as I have seen) are not interacting with such an object here.

Also as far as i have tested that bug is an issue cross platform, this issue ^^ is only on very specific architectures.

At first glance the symptoms appear the same, but digger deeper they are quite different. Ultimately JSC is complex, so it might still be the same issue. But my currently thought is that this is unrelated.

@stefanpenner
Copy link
Member Author

@simi but I would be a huge fan of being wrong.

@toranb
Copy link
Contributor

toranb commented Oct 17, 2014

Anyone know if iOS 8.1 fixes the web :)

I hear a date of Oct 20th ...

@chrisvariety
Copy link
Contributor

FYI, this is not fixed in iOS 8.1 (12B411) on iPhone 5.

@stefanpenner
Copy link
Member Author

FYI: bower users: -> yapplabs/ember-ios8-fix#1.7.0
https://github.com/yapplabs/ember-ios8-fix/tree/1.7.0

Less crazy patch

@ghedamat
Copy link
Contributor

@stefanpenner thanks once more!

@stefanpenner
Copy link
Member Author

canary snapshot with fix:
FYI: bower users: -> yapplabs/ember-ios8-fix
https://github.com/yapplabs/ember-ios8-fix/tree/master
Less crazy patch

@stefanpenner
Copy link
Member Author

@stefanpenner stefanpenner changed the title [workaround for #5606] o_0) apple what have you done.. [workaround for #5606] o_0) iOS 8 non-64bit Object.create bug... Oct 24, 2014
@stefanpenner
Copy link
Member Author

finally had a chance to report a bug, sorry for the delay i hate writing bug reports.

https://bugs.webkit.org/show_bug.cgi?id=138038

@ssured
Copy link
Contributor

ssured commented Nov 5, 2014

For me the iPad mini 1st gen + ios 8.1 + ember 1.8 is broken. My guess browser sniffing should detect iPad too, see also #5606 (comment)
Thanks for your efforts on this bug. It took me half a day to discover this issue, what a waste of time of all of us struggling against ios 8.

@stefanpenner
Copy link
Member Author

ember 1.8 is broken

we fixed additional scenarios on 1.8.1 does your scenario still fail?

@rwjblue FYI

@ssured
Copy link
Contributor

ssured commented Nov 6, 2014

All seems ok on 1.8.1. I hadn’t seen that release before. Thanks

On 05 Nov 2014, at 22:44, Stefan Penner notifications@github.com wrote:

ember 1.8 is broken

we fixed additional scenarios on 1.8.1 does your scenario still fail?


Reply to this email directly or view it on GitHub.

@rwjblue rwjblue deleted the OMG_WTF branch November 29, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet