New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workaround for #5606] o_0) iOS 8 non-64bit Object.create bug... #5629
Conversation
@stefanpenner I just wanted to drop a quick "thank you" for all the hard work you've put into this! You always seem to be one step ahead of me on these interesting bugs - for this and all your other OSS work - thank you, thank you, thank you !!! |
@toranb I could not agree more!!! Thanks @stefanpenner |
https://github.com/kenkouot/ember is a mirror of this patch |
Huge props to @stefanpenner for figuring this out, and just rocking it. 🤘 Bit by this in our own app and I spent a while digging through the Ember source to see if I could monkeypatch it myself, but quickly grew out of my depth. Leave it to the ember.js Thought Leaders™ |
I just wanted to say I love you @stefanpenner !!! |
@eviltrout thanks :) I'm absolutely out of bandwidth this week, but we need to
I'm unsure if you or someone in the community has time, but I could use the help on ^^. cc @twokul |
@stefanpenner I'll take a look at it today, updating view helpers PR atm |
I think it is reported already (https://bugs.webkit.org/show_bug.cgi?id=49739). |
@simi I believe this is different, we (as far as I have seen) are not interacting with such an object here. Also as far as i have tested that bug is an issue cross platform, this issue ^^ is only on very specific architectures. At first glance the symptoms appear the same, but digger deeper they are quite different. Ultimately JSC is complex, so it might still be the same issue. But my currently thought is that this is unrelated. |
@simi but I would be a huge fan of being wrong. |
Anyone know if iOS 8.1 fixes the web :) I hear a date of Oct 20th ... |
FYI, this is not fixed in iOS 8.1 (12B411) on iPhone 5. |
FYI: bower users: -> yapplabs/ember-ios8-fix#1.7.0 Less crazy patch |
@stefanpenner thanks once more! |
canary snapshot with fix: |
another likely related issue: http://stackoverflow.com/questions/25174594/typeerror-attempted-to-assign-to-readonly-property-on-ios8-safari |
finally had a chance to report a bug, sorry for the delay i hate writing bug reports. |
For me the iPad mini 1st gen + ios 8.1 + ember 1.8 is broken. My guess browser sniffing should detect iPad too, see also #5606 (comment) |
we fixed additional scenarios on @rwjblue FYI |
All seems ok on 1.8.1. I hadn’t seen that release before. Thanks On 05 Nov 2014, at 22:44, Stefan Penner notifications@github.com wrote:
|
ghetto hack for #5606 – o_0) that is all
other issues that have popped up turn out to be slightly different, an example of there test is attached bellow but it seems to cause issues for all Safari 8 Versions and platforms, whereas ours seems to only affect some devices.
see: #5606 for more details (I will continue to flesh this out after I sleep)
a more accurate test for something similar... they symptoms are so close i assume it is the same problem, but our scenario is different. But maybe it is a better check?
this test needs 'use strict' and the parentClass to be
window.HTMLElement.prototype
maybe our scenario touches a native object as well?