This repository has been archived by the owner on May 26, 2019. It is now read-only.
Use Public Website Docker Image #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
locks
approved these changes
Oct 16, 2017
|
👍 |
|
I suppose the C.I. stuff could be changed to use docker, too |
|
Just tested this out, works great, if only we'd had this when I got started on guides ... 😀 Thx @NullVoxPopuli 👍 One question. If/when we want to update https://hub.docker.com/r/dockerizedember/website-dev/, what is the process for doing so? Assume (rightly 😉) that you are explaining to a Docker newb ... |
|
All we do push a commit to the corresponding github repo and dockerfile will rebuild. Locally you add the --pull flag to docker compose because we aren't using version tags on this image |
jaredgalanis
pushed a commit
to jaredgalanis/guides
that referenced
this pull request
Feb 17, 2018
* use public docker image * manually specify deps installation to not confuse between projects * update readme * Updated link and removed extraneous Docker info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no impact on contributors. The command to start up the container is still
docker-compose up