This repository has been archived by the owner on May 26, 2019. It is now read-only.
Use injection to access service from test context #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior is supported in ember-qunit 0.4.12, and I think it's nicer than asking users to save their own local variable during init.
michaelrkn
added a commit
that referenced
this pull request
Oct 1, 2015
Use injection to access service from test context
| @@ -272,9 +265,9 @@ test('should change displayed location when current location changes', function | |||
| this.render(hbs`{{location-indicator}}`); | |||
| assert.equal(this.$().text().trim(), 'You currently are located in New York, USA', 'origin location should display'); | |||
| Ember.run(() => { | |||
There was a problem hiding this comment.
I think we can remove the ember.run using this.set now
There was a problem hiding this comment.
Oh yes, that's true. The sets handle their own run loops.
|
I ran the example and it passes so we are good from that end. |
|
@michaelrkn could we get second merge when the above comment is updated? |
|
I'll do a followup PR. |
|
cool |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is supported in ember-qunit 0.4.12, and I think it's nicer than asking users to save their own local variable during init.