-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce resumeTest
to complement pauseTest
?
#146
Comments
The implementation that I have seen was a gist from @stefanpenner, maybe he still has it handy? |
There was also this in the original PR (seems to have gone largely unnoticed): emberjs/ember.js#9383 (comment) |
https://gist.github.com/stefanpenner/0baadd08d0733f9e8ae0#file-pause-test-js although that example uses a getter, which may or may not be of value. |
Would a PR adding this into core be welcome? If so, I'll pull it together with some tests |
I'm not certain how well making a change and resuming will work in practice, but this would be pretty low hanging fruit to add behind a feature flag and experiment with. I'd be +1 to see a PR. :-D |
Agree |
True, but at the very least this will enable the ability to use more than one |
its less about resuming after a change, and more about being able to emulate debugger, without blocking the entire thread of execution. I can say with confidence this pause/resume works really well with acceptance tests. So +1 from me. |
Note: To make the Final Comment Period official, we need to announce it here and on Twitter, so we're restarting the period now. This RFC is now entering a "final comment period". This period is intended to focus the community's attention for a final round of consideration and feedback before an RFC is merged. Please carefully consider the implications of this RFC and how it will affect your Ember projects. Now would be a good time to re-raise any concerns that you feel haven't been fully addressed. If no significant blockers are raised by October 7, we plan to merge this RFC and make plans for its implementation. |
FCP didn't drum up any additional feedback, and we are still 👍 on the feature. Lets do it! |
Closing this issue in favor of emberjs/ember.js#13663 |
The current implementation of
pauseTest
does its job well but it would be nicely complemented by introducing a way to resume the test that gets paused.One particular use case for wanting this is to encourage developers to enable easier debugging/development against Acceptance tests. It's great to pause a test and try changing some things and then resume the test to ensure the rest of the flow works.
One drawback, however, is that any "resume" function would need to be bound to the global context (
window
in almost all cases) so that users can easily invoke it from the console.I know I've seen implementations of this before, but couldn't seem to find any issue pointing to whether or not discussion was had on adding it to the core test helper.
The text was updated successfully, but these errors were encountered: