Add pauseTest test helper

[kategengler]

Adds a helper to pause a test.

[stefanpenner]

👍

[lukemelia]

This is cool. I always forget the syntax for doing this, so it will be great to have a helper! Maybe the docs should have the "why" also. e.g. "This test helper is useful for when debugging a test as it allows you to inspect the state of your application while the test is paused."

[rwjblue]

👍

This adds API so I think it will need to be feature flagged before we can merge...

[stefanpenner]

honestly, i would love to just fast forward this into beta. It should be 2 seconds for the rest of core to vet, if there are actual concerns we can do flags and a full cycle.

[kategengler]

@lukemelia Added the 'why' documentation, thanks!

[pangratz]

I think this should be put out of the code sample, maybe Example (the test will pause before clicking the button):?

[pangratz]

Awesome 👍

[pangratz]

I wonder if it might be useful to have the possibility to continue the tests? Maybe something like:

function pauseTest() {
  Test.adapter.asyncStart();
  return new Ember.RSVP.Promise(function(resolve) {
    debugger
  }, 'TestAdapter paused promise');
}

If the web inspector is open, a resolve() would continue the tests after inspecting/modifying the state ...

[stefanpenner]

@pangratz if you engage a debugger it will also make it impossible to use the dev tools to inspect the DOM and interact with the app.

[pangratz]

@stefanpenner hmm, right...

[pangratz]

What about something along the lines:

function pauseTest() {
  Test.adapter.asyncStart();
  return new Ember.RSVP.Promise(function(resolve) {
    window.continueTest = function() {
      Test.adapter.asyncEnd();
      resolve();
    }
  }, 'TestAdapter paused promise');
}

[rwjblue]

@stefanpenner - The last beta of 1.8 has shipped. I am not comfortable adding any new API surface at the end of a cycle that is not clearly solving a blocking issue. Please realize that this is not a reflection on this code in any way (I agree with it and would like to have this also), it is a point of process and fundamentals to me.

IMHO, new API gets a feature flag (which we can in turn immediately enable for 1.9.0-beta.1 this weekend).

[fivetanley]

also a +1 to rob's thoughts.

also, i have wanted this feature forever but didn't realize that this would be the implementation. i love it

[kategengler]

Added a feature flag. Let me know if I missed anything.

[rwjblue]

@kategengler - Thank you!

[rwjblue]

👍 for enabling in 1.9.0-beta.1. Anyone have objections?

[stefanpenner]

👍

[igorT]

❤️ much nicer than putting debuggers around and plays well with andThen