Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATA] Singleton RecordData #461

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@runspired
Copy link
Contributor

runspired commented Mar 7, 2019

Rendered

@runspired runspired changed the title Singleton RecordData [DATA] Singleton RecordData Mar 7, 2019

@amyrlam amyrlam referenced this pull request Mar 8, 2019

Merged

Ember Times No. 88 - March 8, 2019 #3849

5 of 16 tasks complete

runspired added some commits Mar 8, 2019

@jessica-jordan jessica-jordan referenced this pull request Mar 11, 2019

Merged

The Ember Times No. 89 - March 15th 2019 #3

9 of 15 tasks complete
@igorT

This comment has been minimized.

Copy link
Member

igorT commented Mar 13, 2019

I think this is a great overall approach. Just a couple questions/suggestions:

What happens If you pass in an identifier that RD hasn't seen before to the methods?

Also, it might be helpful if you reiterated what the final RD interface looks like with these changes applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.