Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATA] Singleton RecordData #461

Merged
merged 1 commit into from
Jun 26, 2019
Merged

[DATA] Singleton RecordData #461

merged 1 commit into from
Jun 26, 2019

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Mar 7, 2019 •
edited by hjdivad
Loading

@runspired runspired added T-ember-data RFCs that impact the ember-data library T-deprecation labels Mar 7, 2019
@runspired runspired changed the title Singleton RecordData [DATA] Singleton RecordData Mar 7, 2019
@amyrlam amyrlam mentioned this pull request Mar 8, 2019
Merged
16 tasks
@jayjayjpg jayjayjpg mentioned this pull request Mar 11, 2019
Merged
15 tasks
@igorT
Copy link
Member

igorT commented Mar 13, 2019

I think this is a great overall approach. Just a couple questions/suggestions:

What happens If you pass in an identifier that RD hasn't seen before to the methods?

Also, it might be helpful if you reiterated what the final RD interface looks like with these changes applied.

This was referenced Mar 21, 2019
Merged
Merged
hjdivad
hjdivad reviewed May 15, 2019
View reviewed changes
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
text/0000-ember-data-singleton-record-data.md Outdated Show resolved Hide resolved
@hjdivad
Copy link
Member

hjdivad commented Jun 5, 2019

Per weekly discussion; action item to merge:

  1. the version issue listed inline
  2. drop the discussion of *Manager as it's an implementation detail and distracts from the public API

@igorT
Copy link
Member

igorT commented Jun 5, 2019

@igorT to look into isRecordInUse

@runspired runspired force-pushed the ember-data-singleton-record-data branch 3 times, most recently from e97cecc to 492075c Compare June 26, 2019 21:56
@runspired runspired merged commit 223be3e into emberjs:master Jun 26, 2019
@chriskrycho
Copy link
Contributor

Would someone please be so kind as update the Rendered link to point to the final location of the text? 🙏 Thanks!

@hjdivad
Copy link
Member

hjdivad commented Jul 16, 2019

updated; thanks @chriskrycho

@runspired runspired mentioned this pull request Jul 28, 2022
Closed
@runspired runspired mentioned this pull request Aug 11, 2022
Merged
@runspired runspired mentioned this pull request Sep 12, 2022
Merged
@chriskrycho chriskrycho mentioned this pull request Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjdivad hjdivad hjdivad left review comments

Assignees
No one assigned
Labels
Final Comment Period T-deprecation T-ember-data RFCs that impact the ember-data library
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runspired @igorT @hjdivad @chriskrycho