rfc: ember-data | deprecate-model-reopen #738
Conversation
runspired
added
T-ember-data
| new model types or (better) utilize a megamorphic solution such as ember-m3 to achieve their needs. | ||
|
|
||
| In all cases, using `reopen` after a class instance for a record has already been created has *always* | ||
| resulted in at least minor and potentially major errors in application state. |
There was a problem hiding this comment.
Do you think we could expand on this? Are examples you have seen involve messing with some of the Model states? Overall, I think we can help user's understand a specific case where reopen may have lead them astray.
There was a problem hiding this comment.
Basically there are three issues though I don't think they need to be laid out here in the rfc text itself:
-
is that we cache the metas for relationships and attributes, so if a reopen were to redefine a relationship (or add a potential resolvable inverse to a relationship where none was before) then those definitions would likely not get applied to new instances as expected (we'd use old metas anywhere we pulled from cache which is most places).
-
is that existing instantiated relationships don't get reconfigured which means that if their definition has been changed they are now potentially a significantly different shape.
-
is a subset of (1). Serialization and normalization typically breaks because eachAttribute/eachRelationship will often be missing necessary definitions.
Full Text: Rendered