Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run new RFC checks so CI can pass #870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Nov 23, 2022

No description provided.

@kategengler
Copy link
Member

I think there are parts of the workflow that rely upon this not running for all directories. It needs some testing.

@wagenet
Copy link
Member Author

wagenet commented Nov 23, 2022

At least some of these items are required for CI to be green, so if we don't do this specific thing, we need to find another way to resolve it. See #867 for the issue.

@kategengler
Copy link
Member

I think it's not unreasonable to merge PRs that don't touch RFCs without green CI, until we work this out. None of the CI jobs do anything for changes not under /text and PRs that don't change RFCs are rare.

@sandstrom
Copy link
Contributor

sandstrom commented Dec 7, 2022

image

The PR section used to be browsable (for new RFCs). Now it's mostly noise.

Maybe add a label to all actual RFCs? That way the label filter can be used to get rid of the noise.

@kategengler
Copy link
Member

@sandstrom Newly opened RFCs will have a label of S-Proposed. There are some quick links to filter the list in the README.

But, I suggest that you should also be interested in RFCs moving to Ready for Release, Released, and Recommended: advancing to these stages means the RFC is progressing and there may be changes at these later stages. There are FCPs for both Ready for Release and Recommended.

I suggest filtering to exclude PRs that are in Draft.

@sandstrom
Copy link
Contributor

Thanks @kategengler!

I noticed there is also a project overview, maybe we should link that one too from the README.md?

@kategengler
Copy link
Member

@sandstrom I'm not sure of the status of that project. I think it may have been used to determine statuses for the backlog of RFCs. But, I am working on a dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants